Compare ⋅ ApolloZhu/swift

    public let correctLevel: QRErrorCorrectLevel
    /// If the image codes has a border around its content.
    public let hasBorder: Bool
    private let typeNumber: Int
    private let model: QRCodeModel

    /// Construct a QRCode instance.

@@ -45,10 +44,10 @@

Loading

                 encoding: String.Encoding = .utf8,
                 errorCorrectLevel: QRErrorCorrectLevel = .H,
                 withBorder hasBorder: Bool = true) {
        guard let typeNumber = try? QRCodeType.typeNumber(of: text, errorCorrectLevel: errorCorrectLevel)
            , let model = QRCodeModel(text: text, encoding: encoding, typeNumber: typeNumber, errorCorrectLevel: errorCorrectLevel)
        
        guard let model = QRCodeModel(text: text, encoding: encoding, errorCorrectLevel: errorCorrectLevel)
            else { return nil }
        self.typeNumber = typeNumber

        self.model = model
        self.text = text
        self.correctLevel = errorCorrectLevel

@@ -68,8 +68,10 @@

Loading


extension QRCodeType {
    /// Get the type by string length
    static func typeNumber(of text: String, errorCorrectLevel: QRErrorCorrectLevel) throws -> Int {
        let textLength = text.utf8.count
    static func typeNumber(of text: String, encoding: String.Encoding = .utf8, errorCorrectLevel: QRErrorCorrectLevel) throws -> Int {
        
        let textLength = text.lengthOfBytes(using: encoding)
        
        let maxTypeNumber = QRCodeLimitLength.count

        var type = 1

@@ -30,14 +30,17 @@

Loading

    private let encodedText: QR8bitByte
    private var dataCache: [Int]
    
    init?(text: String, encoding: String.Encoding = .utf8, typeNumber: Int, errorCorrectLevel: QRErrorCorrectLevel) {
    init?(text: String, encoding: String.Encoding = .utf8, errorCorrectLevel: QRErrorCorrectLevel) {
        
        guard let encoded = QR8bitByte(text, encoding: encoding) else {
            return nil
        }
        
        self.encodedText = encoded
        self.typeNumber = typeNumber
        
        guard let newTypeNumber = try? QRCodeType.typeNumber(of: text, encoding: encoding, errorCorrectLevel: errorCorrectLevel) else { return nil }
        
        self.typeNumber = newTypeNumber
        self.errorCorrectLevel = errorCorrectLevel
        guard let dataCache = try? QRCodeModel.createData(
            typeNumber: typeNumber,

Everything is accounted for!

No changes detected that need to be reviewed.

What changes does Codecov check for?

Lines, not adjusted in diff, that have changed coverage data.

Files that introduced coverage data that had none before.

Files that have missing coverage data that once were tracked.

93.71% 100.00% -0.01%

Merge pull request #10 from joaodforce/master

ApolloZhu

d25c50d

CI Passed

93.71% 100.00% -0.03%

Removed unecessary typeNumber property from QRCode Class and Changed typeNumber parameter order for consistency

joaodforce

e2a0583

CI Passed

-2

93.74% 100.00% +0.33%

Moved type calculating to "QRCodeModel.init", changed string size calc to use "lengthOfBytes" instead of ".count"

joaodforce

704d80a

CI Passed

-6

-4

-2

93.40% ø -0.32%

Removed xcscheme added unintentionally

joaodforce

56ac885

CI Passed

Hiding 2 contexual commits

+7

+5

+2

c9deb8b

Files		•	•	•	Coverage
Sources	-1	-1	ø	ø	^-0.01% 93.71%
Project Totals (14 files)	477	447	0	30	93.71%

Navigation	Overlay
`t` Navigate files	`h` Toggle hits
`y` Change url to tip of branch	`m` Toggle misses
`b / v` Jump to prev/next hit line	`p` Toggle partial
`z / x` Jump to prev/next missed or partial line	`1..9` Toggle flags
`shift + o` Open current page in GitHub	`a` Toggle all on
`/ or ?` Show keyboard shortcuts dialog	`c` Toggle context lines or commits

Compare `c9deb8b ... +5 ... d25c50d`

No flags found

Everything is accounted for!

What changes does Codecov check for?

Show failed CI and contexual commits `c`

7 Commits

29	29		public let correctLevel: QRErrorCorrectLevel
30	30		/// If the image codes has a border around its content.
31	31		public let hasBorder: Bool
32		-	private let typeNumber: Int
33	32		private let model: QRCodeModel
34	33
35	34		/// Construct a QRCode instance.

45	44		encoding: String.Encoding = .utf8,
46	45		errorCorrectLevel: QRErrorCorrectLevel = .H,
47	46		withBorder hasBorder: Bool = true) {
48		-	guard let typeNumber = try? QRCodeType.typeNumber(of: text, errorCorrectLevel: errorCorrectLevel)
49		-	, let model = QRCodeModel(text: text, encoding: encoding, typeNumber: typeNumber, errorCorrectLevel: errorCorrectLevel)
	47	+
	48	+	guard let model = QRCodeModel(text: text, encoding: encoding, errorCorrectLevel: errorCorrectLevel)
50	49		else { return nil }
51		-	self.typeNumber = typeNumber
	50	+
52	51		self.model = model
53	52		self.text = text
54	53		self.correctLevel = errorCorrectLevel

68	68
69	69		extension QRCodeType {
70	70		/// Get the type by string length
71		-	static func typeNumber(of text: String, errorCorrectLevel: QRErrorCorrectLevel) throws -> Int {
72		-	let textLength = text.utf8.count
	71	+	static func typeNumber(of text: String, encoding: String.Encoding = .utf8, errorCorrectLevel: QRErrorCorrectLevel) throws -> Int {
	72	+
	73	+	let textLength = text.lengthOfBytes(using: encoding)
	74	+
73	75		let maxTypeNumber = QRCodeLimitLength.count
74	76
75	77		var type = 1

30	30		private let encodedText: QR8bitByte
31	31		private var dataCache: [Int]
32	32
33		-	init?(text: String, encoding: String.Encoding = .utf8, typeNumber: Int, errorCorrectLevel: QRErrorCorrectLevel) {
	33	+	init?(text: String, encoding: String.Encoding = .utf8, errorCorrectLevel: QRErrorCorrectLevel) {
34	34
35	35		guard let encoded = QR8bitByte(text, encoding: encoding) else {
36	36		return nil
37	37		}
38	38
39	39		self.encodedText = encoded
40		-	self.typeNumber = typeNumber
	40	+
	41	+	guard let newTypeNumber = try? QRCodeType.typeNumber(of: text, encoding: encoding, errorCorrectLevel: errorCorrectLevel) else { return nil }
	42	+
	43	+	self.typeNumber = newTypeNumber
41	44		self.errorCorrectLevel = errorCorrectLevel
42	45		guard let dataCache = try? QRCodeModel.createData(
43	46		typeNumber: typeNumber,

Compare c9deb8b ... +5 ... d25c50d

No flags found

Everything is accounted for!

What changes does Codecov check for?

Show failed CI and contexual commits c 7 Commits

Compare `c9deb8b ... +5 ... d25c50d`

Show failed CI and contexual commits `c`

7 Commits